Looks good! Hannes
> Am 15.04.2019 um 16:04 schrieb Priya Lakshmi Muthuswamy > <[email protected]>: > > Hi Hannes, > > updated the webrev, moved those methods to the common superclass. > Yes buildModulePackagesModuleIndex was used only in frames mode, missed to > remove this method when we removed frames support. > > webrev : http://cr.openjdk.java.net/~pmuthuswamy/8222395/webrev.01/ > > Thanks, > Priya > > On 4/12/2019 8:30 PM, Hannes Wallnöfer wrote: >> Hi Priya, >> >> It looks like the addOverviewHeader, addOverviewComment, >> addNavigationBarHeader, and addNavigationBarFooter method implementations >> are identical in both concrete subclasses, so they could be moved to the >> common superclass. >> >> I also noticed that the modules field in ModuleIndexWriter is written to but >> never read. It was previously used in >> AstractModuleIndexWriter::buildModulePackagesIndexFile, but you removed that >> method. >> >> Was that method a remnant of frames mode maybe? I don’t fully understand >> this, but maybe you know what to do about it. >> >> Hannes >> >>> Am 12.04.2019 um 11:34 schrieb Priya Lakshmi Muthuswamy >>> <[email protected]>: >>> >>> Hi, >>> >>> Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8222395 >>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8222395/webrev.00/ >>> >>> Thanks, >>> Priya >>>
