OK, enough imports are disorganized that we should maybe fix this in a
separate changeset.
-- Jon
On 04/17/2019 01:48 PM, Jonathan Gibbons wrote:
As a preliminary comment, please check the imports statements in all
src/ files you have modified.
It looks like your IDE settings may not be set appropriately.
As a general rule, you should use the following order
* java.*
* javax.*
* other imports
Static imports should come after all other imports.
Make sure that all imports from the same package are grouped together.
See these files for examples of imports that need to be cleaned up:
http://cr.openjdk.java.net/~pmuthuswamy/8219998/review.02/webrev/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java.sdiff.html
http://cr.openjdk.java.net/~pmuthuswamy/8219998/review.02/webrev/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java.sdiff.html
I don't expect you to fix all imports in all files, but if you modify
the imports in a file, please make sure they are ordered in a
reasonable manner.
-- Jon
On 04/04/2019 09:24 PM, Priya Lakshmi Muthuswamy wrote:
Hi,
Kindly the review the changes for
https://bugs.openjdk.java.net/browse/JDK-8219998
I have made changes in javadoc structure to remove most of the
singleton lists in html pages.
Introduced section with the style classes.
Made corresponding changes in stylesheet.
http://cr.openjdk.java.net/~pmuthuswamy/8219998/review.02/api/
http://cr.openjdk.java.net/~pmuthuswamy/8219998/review.02/structure/
http://cr.openjdk.java.net/~pmuthuswamy/8219998/review.02/webrev/
Thanks,
Priya
