Hi Jon, The webrev URL was missing in your RFR, but I found it at the expected location:
http://cr.openjdk.java.net/~jjg/8222669/webrev.00/ Now this is quite a bit nicer than my „solution“ for RawHtml length calculation. Obviously, I still have a bit to learn in order to see potential for code cleanup and not assume things are the way they are supposed to be. The only suggestion I have is that there are three almost identical pieces of code that escape a String to a StringBuilder. It would be nice to factor that out into a shared method somewhere. Hannes > Am 17.04.2019 um 22:02 schrieb Jonathan Gibbons <[email protected]>: > > Please review a relatively simple changeset to introduce and use a new class > to explicitly handle HTML entities within an HtmlTree. This allows for some > customized behavior (specifically a character count of 0 for a zero-width > space) and avoids an otherwise unnecessary use of the RawHtml class. > > In addition to introducing the new class, the use of Contents.SPACE and > Contents.ZERO_WIDTH_SPACE is updated to use the new entity constants. > FInally, explicit uses of strings "<", ">" and "&" are updated to > use appropriate new entities. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8222669 > Webrev: https://bugs.openjdk.java.net/browse/JDK-8222669 > >
