Nice, both the code and the resulting HTML turned out simpler than with the first webrev.
+1 Hannes > Am 26.04.2019 um 09:12 schrieb Priya Lakshmi Muthuswamy > <[email protected]>: > > Hi Hannes, > > Thanks for the review. > I have changed the structure with nested div to take advantage of the > indentation via style sheet. > > updated webrev: http://cr.openjdk.java.net/~pmuthuswamy/8221991/webrev.01/ > structure: > http://cr.openjdk.java.net/~pmuthuswamy/8221991/structure/HashMap.html > > Thanks, > Priya > > On 4/25/2019 3:39 PM, Hannes Wallnöfer wrote: >> Looking at the Jira issue some more, I see that Jon suggested to replace the >> old structure with nested <div class=„inheritance“> elements. I think that >> would actually be preferable to your solution of using a single list as it >> would still allow use to define indentation via style sheet. >> >> Hannes >> >> >>> Am 25.04.2019 um 11:47 schrieb Hannes Wallnöfer >>> <[email protected]>: >>> >>> Hi Priya, >>> >>> Looks good to me. >>> >>> It’s a bit sad that we lose the possibility to make the style customizable >>> and have to hard code it in HTML, but I think there’s no way around that, >>> and the cleaner HTML structure is probably worth it. >>> >>> Hannes >>> >>> >>>> Am 25.04.2019 um 08:52 schrieb Priya Lakshmi Muthuswamy >>>> <[email protected]>: >>>> >>>> Hi, >>>> >>>> Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8221991 >>>> >>>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8221991/webrev.00/ >>>> structure:http://cr.openjdk.java.net/~pmuthuswamy/8221991/structure/HashMap.html >>>> >>>> Existing Structure: >>>> <ul class="inheritance"> >>>> <li><a href="../lang/Object.html" title="class in >>>> java.lang">java.lang.Object</a></li> >>>> <li> >>>> <ul class="inheritance"> >>>> <li><a href="AbstractMap.html" title="class in >>>> java.util">java.util.AbstractMap</a><K,V></li> >>>> <li> >>>> <ul class="inheritance"> >>>> <li>java.util.HashMap<K,V></li> >>>> </ul> >>>> </li> >>>> </ul> >>>> </li> >>>> </ul> >>>> Current Structure : >>>> <ul class="inheritance" title="Inheritance Tree"> >>>> <li><a href="../lang/Object.html" title="class in >>>> java.lang">java.lang.Object</a></li> >>>> <li style="margin-left:2em"><a href="AbstractMap.html" title="class in >>>> java.util">java.util.AbstractMap</a><K,V></li> >>>> <li style="margin-left:4em">java.util.HashMap<K,V></li> >>>> </ul> >>>> >>>> Thanks, >>>> Priya >>>>
