On 2/14/20 1:57 PM, Jonathan Gibbons wrote:
4. Marking with in-line comments "Consider this while working on JDK-8238966"
This is about future work on extracting joining-with-a-separator functionality.
I believe those comments have value, even though the issue they mark is not
addressed in this patch. Some of the sites seem to be a low-hanging fruit, but
the point is to consider them as a whole before proceeding with a fix.
As I noted in the review, I don't think these comments belong in the code.
They are interesting work product, however.
That being said, there are (at least) 3 subsets here.
1. composing localizable lists in strings, e.g. for error messages
2. composing non-localizable lists in strings (thinking of the search
index .js files)
3. composing localizable lists in Content nodes
There's also:
4. composing non-localizable lists in Content nodes, such as
comma-separated lists defined by Java syntax
-- Jon
