Thanks Jon, I wasn’t aware of jtreg.SkippedException.

I pushed the change unmodified and filed a bug for using SkippedException:

https://bugs.openjdk.java.net/browse/JDK-8242652 
<https://bugs.openjdk.java.net/browse/JDK-8242652>

Hannes

> Am 14.04.2020 um 18:48 schrieb Jonathan Gibbons <jonathan.gibb...@oracle.com>:
> 
> Looks good to me.
> 
> As a minor enhancement, either now or later, note that jtreg recognizes the 
> use of an exception named 'jtreg.SkippedException` such as the one declared 
> here:
> 
> test/lib/jtreg/SkippedException.java
> 
> This is used to help indicate when a test was skipped for any reason.
> 
> -- Jon
> 
> On 4/2/20 7:57 AM, Hannes Wallnoefer wrote:
>> Please review:
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8241982
>> Webrev: http://cr.openjdk.java.net/~hannesw/8241982/webrev.00/
>> 
>> This makes TestSearchScript.java run with GraalJS in addition to Nashorn, 
>> and potentially with any other compatible JSR-223 JavaScript engine. I have 
>> tested it with both Nashorn and GraalJS. The test is skipped if no 
>> JavaScript engine is available.
>> 
>> Thanks,
>> Hannes

Reply via email to