Jon, then it looks good. Separately. Other javadoc-related entries in that file refer to these resolved issues: 8152313 and 8164597. Should we revisit the corresponding tests as to why they are still problem-listed?
-Pavel > On 29 Jun 2020, at 20:45, Jonathan Gibbons <jonathan.gibb...@oracle.com> > wrote: > > Pavel, > > This is an unusual situation and is intended to be a brief one. > > In normal cases, a test is problem-listed as a result of observing test > failures, and yes, the bug number serves to provide a justification why the > test has been problem-listed. It is for documentation and tracking only, and > has no functional significance. > > In this case, we could use JDK-8248417 which is the issue that describes the > upcoming test failure, and which will provide the fix for the test. > > -- Jon > > On 6/29/20 11:54 AM, Pavel Rappo wrote: >> Jon, >> >> I rarely problem-list tests. Thus, I'm not sure about the semantics of an >> issue mentioned in a problem list entry. To get some insight I looked at >> other entries in that ProblemList.txt. The entries from javac, javap, and >> sjavac I looked at refer to issues that describe *failures* of the >> corresponding problem-listed tests. Those issues are still open. I presume >> an issue tracks the failure and closes together with the corresponding test >> being un-problem-listed. If so, shouldn't we use some other issue for that >> entry? >> >> -Pavel >> >>> On 29 Jun 2020, at 19:14, Jonathan Gibbons <jonathan.gibb...@oracle.com> >>> wrote: >>> >>> Please review a trivial patch to temporarily problem-list a test in 16 >>> ahead of pushing a patch into 15 that will cause the test to fail. The >>> test will be updated and re-enabled after the patch in 15 has been pushed >>> and been forward-ported into 16. >>> >>> -- Jon >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8248492 >>> >>> Patch: >>> >>> >>> hg diff -R open >>> diff -r a8a1b64a0556 test/langtools/ProblemList.txt >>> --- a/test/langtools/ProblemList.txt Mon Jun 29 18:39:40 2020 +0200 >>> +++ b/test/langtools/ProblemList.txt Mon Jun 29 10:37:57 2020 -0700 >>> @@ -26,6 +26,7 @@ >>> ########################################################################### >>> # >>> # javadoc >>> +jdk/javadoc/doclet/testHeadTag/TestHeadTag.java 8248492 generic-all >>> >>> ########################################################################### >>> # >>>
