Hannes, I verified that your links worked on macOS versions of Chrome, Firefox, and Edge.
Looks good to me. -Pavel > On 30 Jul 2020, at 12:07, Hannes Wallnoefer <hannes.wallnoe...@oracle.com> > wrote: > > Please review: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8250779 > Webrev: http://cr.openjdk.java.net/~hannesw/8250779/webrev.00/ > > The fix consists in not calling history.replaceState at the end of the patch > when the current URL has a fragment identifier. > > The rest of the patch consists in consistently using the addEventListener > method to add event listeners instead of using onxxx callbacks. > > You can verify the patch works by loading and reloading the following URLs in > Chrome and making sure the reloaded page scrolls to the position indicated by > the URL fragment: > > http://cr.openjdk.java.net/~hannesw/8250779/api.00/java.base/java/lang/Object.html#method.summary > http://cr.openjdk.java.net/~hannesw/8250779/api.00/java.base/java/lang/Object.html#hashCode() > > Thanks, > Hannes
