On Thu, 26 Nov 2020 16:54:06 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> This is a simple change to throw jtreg.SkippedException if no JavaScript >> engine is available to run the TestSearchScript test. In my previous attempt >> I tried to use the SkippedException class already present elsewhere in the >> test tree, not realizing I couuld just copy/create the exception in the >> javadoc test library. >> >> Note that while the test is skipped correctly if no JS engine is available, >> the test will currently fail in the presence of a JS engine such as GraalJS. >> This is fixed by JDK-8244535. > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Use existing SkippedException class in TestSearchScript.java This change looks good to me. Since you've changed `test/langtools/TEST.ROOT`, please make sure all the langtools tests pass (not just `TestSearchScript.java`) before integrating this change. ------------- Marked as reviewed by prappo (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1412
