On Fri, 18 Dec 2020 17:09:36 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains seven commits: >> >> - Fix failures >> - Merge with upstream/master >> - remove adaptive terminology for records >> - add test >> - Remove obsolete properties and code >> - Version 2: release-specific terminology >> - JDK-8258002: Update "type" terminology in generated docs > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java > line 204: > >> 202: super.initConfiguration(docEnv, resourceKeyMapper); >> 203: contents = new Contents(this); >> 204: } > > I wish initialization of the configuration instance was not that complex... I > guess the reason we must do it this way is that used SourceVersion is not > known earlier. Agreed that initializing the configuration is overly complex. At least in part, it's because of an earlier desire to use final fields where possible, when using direct access. And yes, the problem here is that the `SourceVersion` is not known until `init` is called. ------------- PR: https://git.openjdk.java.net/jdk16/pull/20
