> This implements most suggestions implemented in the JBS issue. The heading > for class entries in the page is shortened to "<element-type-kind> <name>", > followed by a simplified signature line like "class X extends Y implements > Serializable". > > Furthermore, package names in package headings now link to the package page, > `@param` info is added to the methods, Externalizable is used for classes > that implement it. I also added a check for content in `@serial` tags to > avoid spurious empty ` ` lines in the output. > > I increased the font size for headings `h4` to `h6` in the stylesheets > because their size was smaller than the default text size, which looked > strange. Although the change in font size from `h3` to `h4` and beyond is now > smaller I think it's still recognizable. Headings `h4` to `h5` are used very > little in Javadoc (mostly static doc files and the serialized-form page). I > looked at some of the static files and they looked good to me with the new > larger heading fonts. > > Although I didn't end up using the `Signatures` class to generate the class > signatures (they're just too simple and too specific in what they list), I > left in some cleanup of `Signatures.TypeSignature`, most significantly moving > the processing of modifiers from `ClassWriterImpl` to > `Signatures.TypeSignature`. > > I only removed the obsolete resources from the English resource file out of > habit of not touching the Chinese and Japanese ones. I guess I could remove > it there too.
Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision: JDK-8232644: Back out of signature cleanup conflicting with sealed classes changes ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3817/files - new: https://git.openjdk.java.net/jdk/pull/3817/files/9a9e4a49..092af734 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3817&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3817&range=00-01 Stats: 70 lines in 5 files changed: 26 ins; 17 del; 27 mod Patch: https://git.openjdk.java.net/jdk/pull/3817.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3817/head:pull/3817 PR: https://git.openjdk.java.net/jdk/pull/3817
