On Mon, 10 May 2021 14:01:46 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> This replaces usages of the zero-width space character (ZWSP, entity >> `​`) with the HTML5 `<wbr>` element. `<wbr>` acts as a word break >> opportunity without adding characters to the text content like ZWSP does. It >> is supported in all modern browsers, the only browser I know of which >> doesn't support is are old versions of Internet Explorer. >> >> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr >> https://caniuse.com/wbr-element >> >> I have tested the output (both layout and copy-paste behaviour) on Firefox, >> Safari, and Chrome on Mac OS X. > > Hannes Wallnöfer has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8266779 > - JDK-8266779: Use <wbr> instead of ZERO_WIDTH_SPACE It's unfortunate that the text blocks in tests are formatted for a fixed width; diffs are filled with unrelated changes. Update copyright years and you're good to go. Thanks for fixing this, Hannes. src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java line 213: > 211: Content paramTree = getParameters(member, false); > 212: if (paramTree.charCount() > 2) { > 213: // only add zero-width-space for non-empty parameters Update this comment. ------------- Marked as reviewed by prappo (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3946
