On Tue, 18 May 2021 11:00:19 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Please review a trivial fix to avoid creating an unnecessary
>> `BufferedWriter`.
>>
>> `noreg-trivial` (or `noreg-cleanup` : take your pick). Either way, no test.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ElementListWriter.java
> line 79:
>
>> 77: try (Writer fileWriter = file.openWriter();
>> 78: BufferedWriter out = (fileWriter instanceof BufferedWriter
>> b) ? b
>> 79: : new BufferedWriter(file.openWriter())) {
>
> Don't call `file.openWriter()` second time, reuse `fileWriter` that you
> already have.
oops. that's what I meant; thanks
-------------
PR: https://git.openjdk.java.net/jdk/pull/4080
