On Wed, 19 May 2021 19:13:07 GMT, Ian Graves <igra...@openjdk.org> wrote:
>> 8267329: Modernize Javadoc code to use instanceof with pattern matching > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Additiona name refactoring OK, a couple of suggestions, but it would be stylistically consistent to leave some names inconsistent! :-) src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 2136: > 2134: basePath = docPaths.forPackage(pkg); > 2135: } else if (element instanceof ModuleElement modElem) { > 2136: basePath = DocPaths.forModule(modElem); Missed this last time; maybe "mdle" would be more in line with usage elsewhere ------------- Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4105