On Tue, 18 May 2021 18:01:19 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

>> Please review a change for JavaDoc, for the Standard Doclet to copy legal 
>> header files into the generated docs from a default or designated directory.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains four additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8259530
>  - use DocFile.copy to install files
>  - Merge remote-tracking branch 'upstream/master' into JDK-8259530
>  - JDK-8259530: Generated docs contain MIT/GPL-licenced works without 
> reproducing the licence

Update the copyright years and you're good to go.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/StandardDocFileFactory.java
 line 153:

> 151: 
> 152:         /** Create a StandardDocFile for a given location and relative 
> path. */
> 153:         StandardDocFile(Location location, DocPath path) {

Why did you remove these two `private` modifiers?

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3954

Reply via email to