On Tue, 15 Jun 2021 22:18:40 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
> Please review an interim minimal fix to write logging messages from the > javadoc tool to STDERR, not STDOUT. > > Recent work focussed on the use of the `Reporter` API in doclets, including > the standard doclet. This patch aligns the tool code with the same policies > as used in the doclet (and indirectly, in javac.) > > Given we're in RDP1, the fix is intentionally minimal. The direct use of > JavadocLog.printRawLines is a definite code-smell, and the `notice` methods > in `ToolEnvironment` are seemingly obsolete and could be replaced by more > appropriate API in `JavadocLog`. JDK-8268831 is a follow-up issue to address > these issues. Please update the copyright years before integrating. The change looks good; in particular, thanks for filing a follow-up refactoring issue JDK-8268831. ------------- Marked as reviewed by prappo (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/68
