On Thu, 17 Jun 2021 01:35:58 GMT, Jonathan Gibbons <[email protected]> wrote:
> Also:
> JDK-8249897: jdk/javadoc/tool/LangVers.java uses @ignore w/o bug-id
> JDK-8249898: jdk/javadoc/tool/6176978/T6176978.java uses @ignore w/o bug-id
>
> Please review a trivial PR for 17 to remove some tests which have been
> `@ignore`d since at least JDK 9.
> The tests were previously written for the old API and doclet, and were at
> best incompletely updated for the new world.
> The functionality covered by these tests is now better covered in other
> non-ignored tests, and there seems little benefit to trying to update them
> for the new world.
>
> * InlineTagsWithBraces.java was about checking nested `{ }` inside inline
> tags, which is now covered by `doctree` tests for the `DocCommentParser`.
> * LangVers.java was a JDK5-era test, ensuring that the right language level
> was assumed. This is now covered by delegating the relevant options
> (`-source`, `--release`, etc) to javac
> * T6176978.java was about testing classloading of doclets. While we do not
> have any direct replacement tests, we have a variety of tests that load
> custom doclets, and javadoc uses the JavaFileManager API to get a class
> loader for the appropriate path.
Looks good.
-------------
Marked as reviewed by hannesw (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/87
