On Tue, 5 Oct 2021 15:20:33 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
> I agree that the test is overweight for the benefit, but I couldn't think of > a better way to reduce the number of invocations of javadoc and still have a > chance of catching any problem values. What would such problem values be? Have we seen any? I thought that this test simply verifies that if we put a locale on the one end (options), we will receive that same locale on the other end (doclet). Is there more to this test? > I was alerted to this test because I did see it occasionally timing out (on > my local system), and so the intent was to reduce the execution time to avoid > that kind of spurious test failure. I'm open to applying further improvements > if we can come up with any good suggestions. Meanwhile, I propose to > integrate this fix as is. The fact that this test occasionally timed out on your machine surprises me. I mean, it used to take 20 seconds for me. Did it occasionally take more than 300 seconds for you? (AFAIK the default jtreg timeout is 5 minutes.) ------------- PR: https://git.openjdk.java.net/jdk/pull/5814
