On Tue, 12 Oct 2021 15:11:13 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:

>> Please review a moderately simple change, to have DocLint check for relevant 
>> `@SuppressWarnings` annotations before reporting any messages.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Env.java line 302:
> 
>> 300:                     for (String a: arg.substring(len).split(",")) {
>> 301:                         Messages.Group argGroup = gMap.get(a);
>> 302:                         if (argGroup != null) {
> 
> Should we let the user know about unknown doclint:* values?

I thought about this, but in general, the precedent in `SuppressWarnings` is to 
not reject unknown values, because they might be supported by other systems.  
`doclint:*` is "unusual" for suggesting a namespace, by virtual of the `:`  
which might give some justification for rejecting unknown values, but I'm still 
not sure I want to go there at this time.

At some point, there should be more attention to `@SuppressWarnings`, including 
the ability to detect unused/unnecessary uses of the annotation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5870

Reply via email to