On Thu, 14 Oct 2021 14:08:32 GMT, Pavel Rappo <[email protected]> wrote:
> I wonder if this change will negatively affect some downstream tools. Also, > the proposed position of the "MODULE DESCRIPTION" is inconsistent with that > of other markers, such as "PACKAGE DESCRIPTION". Doesn't "PACKAGE > DESCRIPTION" have a similar problem? It's true that placement of marker comments is inconsistent, and there are other places where the marker follows the `section` element or is missing. Maybe the best thing is to retract this pull request (as well as openjdk/jdk#5947) and have a more thorough look. As for breaking tools relying on the exact placement of these markers: That's possible and would be unfortunate, but if we can fix a problem with the output I think we should still do so. ------------- PR: https://git.openjdk.java.net/jdk/pull/5946
