On Fri, 25 Feb 2022 18:03:46 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix outdated code >> >> Uses a set instead of list for quick method search. In a future commit >> we'll try to figure out why `found` are not unique. >> - Fix outdated code >> >> Fix outdated inline comments and names. Both the assertion and the >> `contains` method will be removed in a future commit. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java > line 1183: > >> 1181: } >> 1182: >> 1183: private boolean checkType(TypeElement te) { > > The name isn't great, and seems to be more general than the implementation > might suggest. I agree; could you try to come up with a better one? ------------- PR: https://git.openjdk.java.net/jdk/pull/7233