On Fri, 25 Feb 2022 17:46:05 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Explorative refactoring performed while looking into multiple `@inheritDoc` >> issues. The easiest way to review it is to, probably, go commit by commit; >> they are quite focused and commented. Not only the branch as a whole, but >> all the constituent commits should pass tests and leave JDK API >> Documentation unchanged. > > Pavel Rappo has updated the pull request incrementally with two additional > commits since the last revision: > > - Fix outdated code > > Uses a set instead of list for quick method search. In a future commit > we'll try to figure out why `found` are not unique. > - Fix outdated code > > Fix outdated inline comments and names. Both the assertion and the > `contains` method will be removed in a future commit. > I've looked over the Utils.java class. From my initial reading, I think it would be reasonable to add ElementKind.isExecutable[Element] ElementKind.isVariable[Element] ElementKind.isDeclaredType() // isClass || isInterface currently I'm less convinced of the benefit of adding various "isFoo()" methods. I've filed JDK-8282411: Add useful predicates to ElementKind to track this work. ------------- PR: https://git.openjdk.java.net/jdk/pull/7233
