On Fri, 13 May 2022 13:49:21 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> This updates jQuery UI (which is used for the javadoc in-age search feature) > to version 1.13.1. > > Rendered documentation is available here: > http://cr.openjdk.java.net/~hannesw/8284367/api.00/ > > I noticed that we are carrying a lot of files from the jQuery UI distribution > that we don't really need. this includes the jquery-ui.structure.css files > (both minified and non-minified) as well as the icon image files. These files > are not used or referenced anywhere in our generated documentation so I > removed them instead of updating them. > > I also decided to update to the unthemed jQuery UI version as wee don't > really use the theme. > > Some minor changes in our stylesheets were required to avoid unwanted layout > changes: > > - Add a definition for 1px border around the selelcted list item in our > jquery-ui.overrides CSS file. Without this, the the new jQuery UI would > display a blue border or no border at all depending on the theme. The border > is now orange so it is not distinguishable from the selected background, but > it is necessary to keep the item in the same position when it is selected. > - Remove the `font-size: 13px` property from the `.result-item` class. This > was necessary because previously this class used `font-family: Verdana` from > the jQuery UI theme which looks bigger and is also inconsistent with the > fonts we use in the rest of the page. Now that the search result list uses > the same fonts as the rest of the page we can go back to using the inherited > font size. I left the `font-size` property and changed the value to `inherit` > because our tests don't like CSS classes that are not present in the > stylesheet. > - Finally I had to add a property to the `ul.ui-autocomplete` list to > explicitly set the background to white. The update made the background > transparent. I'm not sure if this is a result of the missing theme but it was > simple enough to fix. This pull request has now been integrated. Changeset: ac41b78c Author: Hannes Wallnöfer <hann...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/ac41b78cfbb94f0b0e9a15cfcc50bdddc43811e9 Stats: 889 lines in 12 files changed: 125 ins; 697 del; 67 mod 8284367: JQuery UI upgrade from 1.12.1 to 1.13.1 Reviewed-by: jjg ------------- PR: https://git.openjdk.java.net/jdk/pull/8702
