On Mon, 4 Jul 2022 15:09:50 GMT, Andrey Turbanov <[email protected]> wrote:
>> Instead of pair `LinkedHashMap.get`+`LinkedHashMap.remove` calls, we can use >> value returned from single `allTaglets.remove` call. >> It's shorter and a bit faster. >> https://github.com/openjdk/jdk/blob/d46f404b3179c66e8e5775a9e2253c95238153c7/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java#L314-L325 > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into > avoid_redundant_LinkedHashmap.get_in_TaglegManager > - [PATCH] Avoid redundant LinkedHashMap.get call in > TagletManager.addNewSimpleCustomTag I don't have any opinion on the comment that Jon is asking about, but I checked the tests and they passed. So in this regard, the change looks good. While I could live without any comment, please work with Jon to find a compromise. ------------- Marked as reviewed by prappo (Reviewer). PR: https://git.openjdk.org/jdk/pull/9137
