On Thu, 11 Aug 2022 15:29:46 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review a change to use CSS custom properties (aka variables) to define > the fonts and colors in generated documentation. It is now possible to change > the fonts and colors of generated API documentation by changing the values of > these properties directly or by using extra stylesheet. > > [Documentation rendered with the updated stylesheet][docs] is mostly > identical pixel-by-pixel to the previous documentation with very few > exceptions: > > [docs]: http://cr.openjdk.java.net/~hannesw/8289334/api.00/ > > - Some colors have been unified to reduce the number of variable definitions: > - Single pixel borders used in class documentation pages use a single > shade of gray (most visible in headers of member details which now have light > gray instead of a darker gray border) > - Header cells of user defined tables now use the same color as > structural tables > - Some sub-pixel sizing and spacing changes in random places > > Contrary to previously stated intention I did not change the stylesheet to > become more flexible (e.g. to allow combinations of background and foreground > colors that are not currently supported). The reason is that this would have > at least doubled the number of color properties and required new CSS rules, > increasing the complexity of the style sheet and risking to add new bugs. > Reducing the number of variables makes it easier to customize the layout and > also preserves part of the original design by reducing the number of colors > to a smaller color palette > > The only code change is due to the removal of `jquery-ui-overrides.css` which > had to be integrated into the main stylesheet in order to make use of CSS > custom properties. This pull request has now been integrated. Changeset: d5435642 Author: Hannes Wallnöfer <hann...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/d5435642f9671766ecbcbf744ecd8e62fb929a69 Stats: 245 lines in 11 files changed: 51 ins; 48 del; 146 mod 8289334: Use CSS variables to define fonts and colors Reviewed-by: jjg ------------- PR: https://git.openjdk.org/jdk/pull/9839
