On Tue, 24 Jan 2023 15:26:27 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright changed, added the bug ID to TestLinkPlatform. > > This looks good to me. A few minor issues: > > - The year in the copyright headers of modified files should be updated to > 2023 > - The bug id should be added to the @bug field of tests that have been > significantly changed (I think only TestLinkPlatform.java in this case) > - I wonder if for those tests that are hard-coded to release 8 we should add > tests for release >= 10? @hns > * I wonder if for those tests that are hard-coded to release 8 we should add > tests for release >= 10? I'm not sure about it. TestLinkPlatform seems OK now, it covers both cases, but doesn't check 'element-list' file existance. Other changed tests are affected because of they use 'package-list' file in the folder specified by '-linkoffline' option, not because of 'source 8'. There are some javadoc tests which use 'element-list' file currently, but they don't check anchor names. To make sure we check both cases, in a part of the affected tests we could use 'element-list' file instead, so we could cover both cases. ------------- PR: https://git.openjdk.org/jdk/pull/12066
