On Wed, 1 Feb 2023 18:12:06 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright years >> - Clean up emptiness conditions >> >> Removes one useless condition; restructures the other, as suggested in >> the review. In each case moves the iterator into the loop to reduce >> that iterator's scope. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java > line 405: > >> 403: throws DocletException { >> 404: Iterator<VariableElement> members = >> utils.serializableFields(currentTypeElement).iterator(); >> 405: if (members.hasNext()) { > > Same comment as above I updated those two locations you mentioned, but decided not to static import `Objects.equals`: see e8d07a12fa2c3ac7a5a21edf28ecb40e685603ac. ------------- PR: https://git.openjdk.org/jdk/pull/12369