On Wed, 8 Mar 2023 14:58:14 GMT, Pavel Rappo <[email protected]> wrote:
>> Please review this explorative refactoring for VisibleMemberTable (VMT). >> >> This is the first round of refactoring for VMT. This round is about *method >> members*: declared (overriding and not) and inherited. >> >> During this work I gained some insight into internal workings of VMT, fixed >> what was feasible and left TODOs and FIXMEs for everything else. Leaving >> those comments might look untidy, but leaving them out is wasteful: they >> clearly mark issues that should be revisited in upcoming rounds of >> refactoring. >> >> As I see it today, the main issue with VMT is that implements complex and >> error-prone computations from Java Language Specification (JLS) by hand. For >> example, VMT interprets JLS rules for relations such as _inherits_, >> _overrides_ and _hides_. As one would imagine, sometimes VMT does it >> incorrectly. It would be better to eventually re-implement VMT using >> `javax.lang.model` as much as possible. Unlike that of `jdk.javadoc`, the >> day job of `javax.lang.model` is to provide JLS services. > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to feedback Approved, although there are still some outstanding suggestions for comments. Generally, this is obviously a big project, so well done on progress so far. It is well worth aligning the functionality and terminology of this code with current JLS, and so I (generally) encourage JLS references in key places, preferably in a stylized manner (to facilitate checking and/or updates). I also think it is worth adding notes comparing the functionality here with that of plain-old `Elements.getAllMembers`. That is a simple building block that returns a list-y set of the members of a `TypeElement`, but VMT needs to do more: * handle members of so-called hidden types * build a DAG for each method, relating that method to corresponding methods in the supertypes of the type element, for use by `@link` and `Specified By:`. * ... ------------- Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.org/jdk/pull/12887
