On Fri, 24 Mar 2023 15:29:30 GMT, Hannes Wallnöfer <[email protected]> wrote:

> Please review a change to address accessibility issues with the 
> copy-to-clipboard buttons in JavaDoc-generated documentation. The most 
> important change is to make these button work for keyboard users, which means 
> buttons must exist in the DOM regardless of mouse position, be visible and 
> readable on keyboard focus (via tab key) and show feedback after keyboard 
> activation (via space or enter key). 
> 
> It also includes a few smaller improvements. The buttons for headings now 
> show a "Copy" label when directly hovered above, and there is a slightly more 
> helpful "Copy URL" or "Copy snippet" label as `aria-label` attribute.
> 
> Incidentally I discovered that the regex pattern in 
> `CheckStylesheetClasses.java` did not pick up all CSS classes, so I 
> simplified the pattern and added a few previously undetected classes to the 
> test.

I uploaded a copy of API docs generated with this chaange. The documentation 
for `java.lang.Thread` is a good place to test the new copy-to-clipboard 
behaviour:

https://cr.openjdk.org/~hannesw/8299718/api.00/java.base/java/lang/Thread.html

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13176#issuecomment-1486806303

Reply via email to