On Tue, 4 Apr 2023 20:55:33 GMT, Jonathan Gibbons <[email protected]> wrote:
> Please remove a simple cleanup fix, to remove unnecessary assignments to set
> the `newline` flag to `true` in `DocCommentParser`. The flag is always set
> appropriately in `nextChar()`.
>
> This removes a number of "fall-through" cases in switch statements. In
> reviewing the use of `@SuppressWarnings("fall through")` it was noted that
> there is a missing `break` in `case '@'` in `inlineWord()`. Fixing this
> breaks a test. This will be addressed separately.
> [JDK-8305620](https://bugs.openjdk.org/browse/JDK-8305620)
This pull request has now been integrated.
Changeset: 5919fad1
Author: Jonathan Gibbons <[email protected]>
URL:
https://git.openjdk.org/jdk/commit/5919fad1f4969ef3faaa0e8fe60ed6e4e15e5cff
Stats: 19 lines in 1 file changed: 0 ins; 19 del; 0 mod
8305591: Cleanup use of `newline` flag in DocCommentParser
Reviewed-by: hannesw
-------------
PR: https://git.openjdk.org/jdk/pull/13341