On Tue, 11 Apr 2023 21:09:27 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Please review more cleanup for DocCommentParser, primarily focused on using >> enhanced switch statements and expressions. >> >> The first commit is mostly IDE-automated. >> The second commit is manual. >> >> All change are "local". There are two remaining switch statements using the >> old form that have non-trivial fall-through code, which could/should be >> moved out into separate methods. > > Jonathan Gibbons has updated the pull request incrementally with one > additional commit since the last revision: > > revert conflicting change Looks good to me, but the 4th commit adding back the `loop` label doesn't seem to be necessary. src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 596: > 594: textStart = -1; > 595: > 596: loop: This label doesn't seem to be used, why was it added back? ------------- Marked as reviewed by hannesw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13362#pullrequestreview-1387771931 PR Review Comment: https://git.openjdk.org/jdk/pull/13362#discussion_r1168510000
