On Wed, 19 Apr 2023 14:17:57 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Please review a cleanup in DocCommentParser to merge blockContent and
>> inlineContent into a single method to parse "rich content" in a doc comment.
>>
>> **Note:** This is dependent on PR #13362, to convert `DocCommentParser` to
>> use enhanced switch.
>
> Jonathan Gibbons has updated the pull request incrementally with one
> additional commit since the last revision:
>
> address review feedback
src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
line 84:
> 82: /** The initial part of a doc comment, or the rich-text content
> of a block tag. */
> 83: BODY,
> 84: /** The end of an HTML file, from and including the {@code
> </main>} or {@code </body>} tag. */
Shouldn't there be the adjective _possible_ similarly to PREAMBLE? I assume,
the idea here is as follows. The `body` element encloses the optional `main`
element. If the `main` element is enclosed, then the PREAMBLE phase ends with
the `main` start tag and the POSTAMBLE phase starts with the `main` end tag.
Otherwise, PREAMBLE ends with the `body` start tag and POSTAMBLE starts with
the `body` end tag. Is this correct?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13431#discussion_r1171541012
