On Thu, 11 May 2023 08:50:55 GMT, KIRIYAMA Takuya <d...@openjdk.org> wrote:
>> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices　option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/ directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and >> ASSEMBLY_EXCEPTION. >> >> Would you please review this fix? > > KIRIYAMA Takuya has updated the pull request incrementally with one > additional commit since the last revision: > > 8306980: Generated docs should contain correct GPLv2 Legal Documents Bundling duplicate files is inefficient. Since the existing design references files under java.base, isn't it reasonable to use those files? ------------- PR Comment: https://git.openjdk.org/jdk/pull/13686#issuecomment-1552935328
