On Wed, 7 Jun 2023 10:27:19 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Please review a simple change to avoid adding section index items (added in >> JDK-8286470) from appearing in the static index pages where the tend to >> cause trouble. >> >> The change is implemented by making `IndexItem.isTagItem()` behave true to >> its specification again and only return `true` if it actually represents a >> JavaDoc tag, and add a new `IndexItem.isSectionItem()` method for the new >> section index items. The new method is used to make sure section links are >> not listed in the index pages. > > Hannes Wallnöfer has refreshed the contents of this pull request, and > previous commits have been removed. The incremental views will show > differences compared to the previous content of the PR. The pull request > contains one new commit since the last revision: > > Include sections in index pages but restrict key characters Note that most items with leading non-java-identifier-start characters are now grouped at the beginning of each section. To avoid this, we'd have to tweak the `Comparator` used for these listings, which is out of scope for this change. <img width="894" alt="Screenshot 2023-06-07 at 12 56 00" src="https://github.com/openjdk/jdk/assets/15975/74b9f30c-df3b-419a-93d5-0817673532f1"> ------------- PR Comment: https://git.openjdk.org/jdk/pull/14312#issuecomment-1580636737