On Thu, 27 Jul 2023 16:47:00 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

> Please review a fairly simple change, to simply rename methods in the 
> `Comparators` class, to remove the `make` prefix from the method names, and 
> (for consistency) in one case, remove `get`.  There are some updates to the 
> more problematic javadoc comments as well.
> 
> It would be nice to think that the implementation of some methods could be 
> improved by chaining use of simpler standard comparators, but that would be a 
> different task.

@jonathan-gibbons I also suspect comparators can be unified/simplified. There 
is a JBS issue for this and I plan to look into this soon. 
https://bugs.openjdk.org/browse/JDK-8256984

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15057#issuecomment-1655428873

Reply via email to