On Wed, 9 Aug 2023 06:57:51 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> I wish there was a way to reduce the number of `.resolve` calls in >> `HtmlDoclet.init`, since they do clutter up the code a bit. >> >> However, I don't have any simple fixups, and such suggestions that I have >> would be a bigger change than is probably warranted here. For example, >> >> copyResources(Path toDir, String... resources) >> >> >> Maybe next time, unless you're feeling keen and eager now. >> >> Approved by default. > >> >> ``` >> copyResources(Path toDir, String... resources) >> ``` >> > > I would have liked to simplify the code further, but apart from different > destinations, there's also different handling of newline character > replacement (even within the same file type), so the resulting code would not > be much more compact than the current 20 lines. @hns Sorry to hijack this thread a bit, but... do you know if the behaviour described in https://github.com/mnlipp/jdrupes-mdoclet/pull/24 is according to spec? :thinking: Quoting @slovdahl: > I did a deep dive into JDK internals but I have not found any way to make > files like search.js.template from inside the jdk.javadoc module available to > outside classes, no matter what --add-opens or --add-exports flags are used. > What makes it even more interesting is that files like jquery-ui.js and > jquery-3.6.1.js are included in the output. > * Included: > /jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.6.1.min.js > * Not included: > /jdk/javadoc/internal/doclets/formats/html/resources/search.js.template [This email](https://mail.openjdk.org/pipermail/jpms-spec-experts/2016-September/000392.html) from `jpms-spec-experts` (Sep 2016) seems to indicate that this is "by design", but is there any other authoritative source for this? ------------- PR Comment: https://git.openjdk.org/jdk/pull/15180#issuecomment-1831324706
