On Wed, 29 Nov 2023 14:30:50 GMT, Jim Laskey <[email protected]> wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Windows line endings
javac changes seem reasonably to me. Adding two nits to `InstanceMainTest.java`.
test/jdk/tools/launcher/InstanceMainTest.java line 45:
> 43: """,
> 44:
> 45: // instance dominating instance
Nit:
Suggestion:
// instance dominating static
test/jdk/tools/launcher/InstanceMainTest.java line 84:
> 82: """,
> 83:
> 84: // unnamed class dominating instance
Nit:
Suggestion:
// main with args dominating main without args
-------------
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16461#pullrequestreview-1755452564
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1409394109
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1409395226
