On Mon, 8 Jan 2024 13:23:02 GMT, Thomas Schatzl <tscha...@openjdk.org> wrote:
> Hi all, > > please review this small fix to increase max heap size for the test to let > it pass with GenZGC and Parallel GC as well. > > The test has at least 660m of live data, so the default 768m provided by > testng is too small for these collectors. > > Testing: local testing > > Hth, > Thomas I have a few questions on this PR. Firstly, general: how come this PR hasn't been reviewed by jshell people? I appreciate that the change is about GCs, but generally a PR should be reviewed by experts in all areas that that PR touches. Secondly, is that correct that the Skara bot [applied] the "javadoc" label but not "kulla" to a test that belongs to jshell? (CC'ing @jonathan-gibbons and @lahodaj.) To be clear, I see the respective [rules] in place, but I wonder if they are correct. [applied]: https://github.com/openjdk/jdk/pull/17304#issuecomment-1881003029 [rules]: https://github.com/openjdk/skara/blob/ef8238c35070094e979a13ad872d105f883f3881/config/mailinglist/rules/jdk.json#L457-L474 ------------- PR Comment: https://git.openjdk.org/jdk/pull/17304#issuecomment-1883157740
