On Tue, 30 Jan 2024 10:10:40 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Adjust test string
>> - Adjust test string
>> - Merge remote-tracking branch 'upstream/master' into
>> 8322865.aggregator-modules
>> - Fix comment intro
>> - JDK-8322865: JavaDoc fails on aggregator modules
>
> test/langtools/jdk/javadoc/doclet/testModules/TestAggregatorModule.java line
> 91:
>
>> 89:
>> 90: out.println("Checking for error message");
>> 91: if (outputLines.stream().anyMatch(l -> l.contains("No public
>> classes"))) {
>
> Minor: the JBS issue suggests the error message was "error: No public or
> protected classes found to document", which would not match this check.
Good catch. I broadened the check to just "No public", here and in another
place as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17272#discussion_r1483731516
