On Thu, 4 Jan 2024 21:06:17 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
> Please review a simple fix to address an apparently long-standing issue of > generating a redirection loop in the top-level `index.html` file. > > The fix is simply to remove some obsolete/unnecessary code in > `HtmlConfiguration.setTopFile` that silently and incorrectly short-circuited > the functionality of that method. > > In addition to the fix, an `assert` statement is added in > `IndexRedirectWriter` to ensure that invalid arguments are not provided. (An > alternative would be explicit `if` statements than can throw NPE or ILA. > > The test case is when there are no classes or interfaces specified in the > command-line arguments. This pull request has now been integrated. Changeset: b3e0587e Author: Jonathan Gibbons <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/b3e0587ea0de9beac57bfeb075c4abd07182694c Stats: 83 lines in 3 files changed: 71 ins; 12 del; 0 mod 8322874: Redirection loop in index.html Reviewed-by: hannesw ------------- PR: https://git.openjdk.org/jdk/pull/17270
