On Mon, 12 Feb 2024 15:37:05 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:

> Please review a change to simplify generation of breadcrumb navigation links. 
> We previously used generic methods to generate the links which didn't allow 
> to tailor the links for our needs and was also more verbose. The change adds 
> a protected `getBreadcrumbLink` method to `HtmlDocletWriter` which makes the 
> link generation code much simpler.
> 
> I added a check to the existing `TestPreview` test to make sure no PREVIEW 
> links are generated for preview elements in the sub-navigation bar.

This pull request has now been integrated.

Changeset: f8d8eecf
Author:    Hannes Wallnöfer <hann...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/f8d8eecf8041a8baa76ba0091f2842dcb0275cb3
Stats:     123 lines in 11 files changed: 68 ins; 34 del; 21 mod

8325325: Breadcrumb navigation shows preview link for modules and packages

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/jdk/pull/17809

Reply via email to