On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >> >> public class ArrayAnno { >> @Retention(RetentionPolicy.RUNTIME) >> @Target(ElementType.TYPE_USE) >> @Documented >> public @interface Anno { int value(); } >> >> public void method(@Anno(1) int @Anno(2) [] @Anno(3) [] arg) {} >> public void method(@Anno(1) String @Anno(2) [] @Anno(3) [] arg) {} >> } >> >> JDK 21: https://cr.openjdk.org/~liach/8325433-arrayanno/old/ArrayAnno.html >> This patch: >> https://cr.openjdk.org/~liach/8325433-arrayanno/new/ArrayAnno.html >> >> Note that a bug within javac (reported in >> https://bugs.openjdk.org/browse/JDK-8327824) causes the annotations to >> become `@Anno(1) String @Anno(3) [] @Anno(2) []` in the output files; this >> bug also affects output class files so I assume this is a bug within javac's >> tree building. (Intersting, the buggy javadoc output was copied wholesale in >> the original `TestTypeAnnotations` output for `array2Deep` cases, but no one >> paid attention to it) > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Redundant imports Thanks for taking care of it. The approach seems good. I've submitted this change to our CI system. Once the results are back, I'll let you know. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18179#issuecomment-1988996333
