On Mon, 11 Mar 2024 13:37:54 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review a change to improve the user experience and implementation for > the checkbox-based interface to selectively display content on API summary > pages: > > - Add a checkbox to toggle (select/unselect) all checkboxes in the page. > - Remove the `Table.setAlwaysShowDefaultTab(boolean)` setter as it is > redundant and can be replaced by `!renderTabs`. > - Consolidate the code to generate checkboxes into a new protected > `SummaryListWriter.getCheckbox` method. It'd work for a few more years, but it doesn't scale well. On the other hand, it is very simple: <img width="850" alt="image" src="https://github.com/openjdk/jdk/assets/32523691/26919228-db98-4041-833f-f01c34125331";> Nit: if you check "all" and then uncheck something else, then "all" will remain selected. That is a confusing state. <img width="846" alt="image" src="https://github.com/openjdk/jdk/assets/32523691/49c1d803-57b3-483b-857f-64781bf96ce0";> I'll have a look at the code change a bit later. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18194#issuecomment-1989120925
