On Tue, 12 Mar 2024 03:33:38 GMT, Chen Liang <li...@openjdk.org> wrote:
> Please review this patch that fixes placement of type annotations on array > types in Javadoc output. This oversight seems to have existed since JDK 8 but > was never noticed or reported. I looked into it; that wasn't easy 😅. 7 years ago a seemingly similar bug, <https://bugs.openjdk.org/browse/JDK-8068737>, was fixed in _javac_. It's only now that javadoc is catching up. Your change seems to be correct, but it disrupts the visitor's pattern. On the other hand, maybe keeping the change confined to `visitArray` is for the better here. Here's what's left to be done: - resolve merge conflicts due to recently integrated https://github.com/openjdk/jdk/pull/18179 - add a couple more test cases; for example, the JLS one that I mentioned earlier and maybe extract something from JBS-8068737 Thanks for doing it. ------------- PR Review: https://git.openjdk.org/jdk/pull/18211#pullrequestreview-1932537513
