On Thu, 4 Apr 2024 13:53:57 GMT, Chen Liang <[email protected]> wrote:
>> The answer to your latter question is no. The id that will be assigned to
>> that public method do depend on whether the private overload positioned
>> before it is documented. You cannot do much about it with the current design
>> of `VisibleMemberTable` without unduly complicating this PR. On the bright
>> side, I reckon such a case is extremely rare.
>
> That's actually a sign of relief that the same elements will have the same id
> with the same input source code
Reading your reply, I think that one of us is likely confused. Your question to
which I replied "no" was this:
> Will the Number public method be consistently erased whether or not -private
> is set?
I replied "no", which means that the id that the public method has DO depend on
whether `-private` is specified. Let me expand on that.
If `-private` is specified, the "Method Details" section will have this for the
public method:
<section class="detail" id="method(java.lang.Number)">
<h3>method</h3>
and this for the private method:
<section class="detail" id="method(T)">
<h3 id="method(java.lang.Runnable)">method</h3>
Otherwise, the "Method Details" section will only have this for the public
method:
<section class="detail" id="method(T)">
<h3 id="method(java.lang.Number)">method</h3>
As you can see, depending on whether `-private` is specified, the section id
for the public method will be different.
Is that how you understood my reply and felt relief after that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18519#discussion_r1551839067
