On Wed, 1 May 2024 20:40:00 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

> > There should be some quick testing of the new default method on Elements 
> > using the VacuousElements implementation; see 
> > `test/langtools/tools/javac/processing/model/util/elements` for some 
> > examples.
> 
> @jddarcy I've reorganized the tests in this area a bit, and moved the testing 
> for `DocCommentKind` to a new test, which includes testing the default 
> method, using `VacuousElements` (nice trick, that, by the way.). Although now 
> renamed, the older `TestGetDocComments` is now closer to the original form, 
> with the testing for `getDocCommentKind` being moved to a new test class.

Creating one VacuousElements was preferable to creating one each time a new 
default method was added :-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16388#issuecomment-2099322156

Reply via email to