On Thu, 18 Apr 2024 12:11:56 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review a change to move a long-running shellsupport test from > langtools tier1 to tier2, while modifying the tier1 test to only retrieve doc > comments for members of `java.lang.StringBuilder`, which is where [the > original bug](https://bugs.openjdk.org/browse/JDK-8189778) occurred. This > reduces the running time in the tier1 test from around 90 seconds to 2 > seconds on my computer. The tier1 test also adds a non-null check for > retrieved doc comments. > > I used the existing `langtools_jshell_unstable` test group to add the new > test in langtools tier2, which is not a perfect match for the test, but close > enough and helps to keep langtools `TEST.groups` file simple. This pull request has now been integrated. Changeset: fa043aec Author: Hannes Wallnöfer <hann...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/fa043aec425ae1e3086d09492b3fabcfbd3fa779 Stats: 96 lines in 3 files changed: 87 ins; 0 del; 9 mod 8294880: Review running time of jdk/internal/shellsupport/doc/JavadocHelperTest.java Reviewed-by: jjg ------------- PR: https://git.openjdk.org/jdk/pull/18837
