On Sun, 12 May 2024 08:36:44 GMT, Chen Liang <[email protected]> wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced by CF API-based new
> code;
> - many in javac are because the files are compiled with older source
> compatibility. Those patches are converted to have the source code stored in
> text blocks and compiled within tests using `ToolBox#writeJavaFiles` and
> `CompilerUtils.compile`;
> - As described in the JBS issue, there are a few other tests not covered;
> one is in #19193 while the others are blocked by CreateSymbols migration or
> bugs.
>
> Testing: all modified tests pass.
test/jdk/jdk/internal/reflect/CallerSensitive/CallerSensitiveFinder.java line
125:
> 123: && invoke.method() instanceof MethodRefEntry ref
> 124: && ref.owner().name().equalsString(className)
> 125: && ref.name().equalsString(methodName)) {
Is this additional test necessary, I don't see it in the original test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19206#discussion_r1604394473
