On Wed, 5 Jun 2024 11:04:06 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review feedback > > test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java line 161: > >> 159: </ol>"""); >> 160: >> 161: // 8331947: Support preview features without JEP should not be >> included in Preview API page > > Trivial: here it is phrased as "Support preview features", while in the > actual test source file it is "Preview support feature". I agree the terminology in comments is somewhat inconsistent. I don't think there is an "official" term for these preview features. [In the CSR](https://bugs.openjdk.org/browse/JDK-8329634) they are summarized as follows: "Add a set of persistent preview visitors to support new language changes in development." I think the essential property for our purpose is the "without JEP". I added the "support" adjective to make their purpose clearer, but I don't think it's essential. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19344#discussion_r1627680852
