On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Can I please get a review for this change, that aims to add support for > Global HTML tags. > Here is the > [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) > to the generated docs. > Thanks in advance. src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 694: > 692: // without checking the validity or applicability of the name > 693: // custom "data-*" attributes are also accepted > 694: var attrName=name.toString(); Suggestion: var attrName = name.toString(); src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 513: > 511: VSPACE, > 512: WIDTH, > 513: ACCESSKEY, Maybe add a comment `// Global attributes` above this line to indicate the start of global attributes, so future attributes are added to the correct section? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634727172 PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634727032
